Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Stackoverflow for simpledoc #958

Merged
merged 1 commit into from Jun 21, 2023
Merged

Fixed Stackoverflow for simpledoc #958

merged 1 commit into from Jun 21, 2023

Conversation

neilnaveen
Copy link
Contributor

@neilnaveen neilnaveen commented Jun 20, 2023 •
edited

Description of the PR

  • included tests for validateSimpleDoc
  • fixed stackoverflow issue in validateSimpleDoc

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@neilnaveen
Fixed Stackoverflow for simpledoc
56ad3df 
- included tests for validateSimpleDoc
- fixed stackoverflow issue in validateSimpleDoc

Signed-off-by: Neil Naveen <42328488+neilnaveen@users.noreply.github.com>
@kodiakhq kodiakhq bot merged commit e1c36ff into guacsec:main Jun 21, 2023
8 checks passed
@neilnaveen
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@pxp928 pxp928 pxp928 approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@neilnaveen @mihaimaruseac @pxp928