Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

special case for arch x86_64 should be converted to amd64 for GOARCH … #968

Merged
merged 1 commit into from Jun 22, 2023
Merged

special case for arch x86_64 should be converted to amd64 for GOARCH … #968

merged 1 commit into from Jun 22, 2023

Conversation

lumjjb
Copy link
Contributor

@lumjjb lumjjb commented Jun 22, 2023

…consistency

Description of the PR

Fix issue when building and tagging container via make container because uname -m returns x86_64 but container ecosystem uses amd64

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@lumjjb
special case for arch x86_64 should be converted to amd64 for GOARCH …
b147cb6 
…consistency

Signed-off-by: Brandon Lum <lumjjb@gmail.com>
@lumjjb lumjjb requested a review from sunnyyip June 22, 2023 16:58
sunnyyip
sunnyyip approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@sunnyyip sunnyyip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix!

@kodiakhq kodiakhq bot merged commit b0defd6 into main Jun 22, 2023
8 checks passed
@kodiakhq kodiakhq bot deleted the fix-make-container branch June 22, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunnyyip sunnyyip sunnyyip approved these changes

@pxp928 pxp928 pxp928 approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lumjjb @sunnyyip @pxp928