getTopLevelPackage will now check DESCRIBES and DESCRIBED_BY relation… #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumjjb
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Minor nits, else LGTM! Thanks @CrossedSecurity for helping with this!
CrossedSecurity
force-pushed
the
spdx-describes-2
branch
2 times, most recently
from
64b62be
to
4b12f15
Compare
pxp928
reviewed
Jun 29, 2023
CrossedSecurity
force-pushed
the
spdx-describes-2
branch
from
4b12f15
to
9c90a4e
Compare
CrossedSecurity
force-pushed
the
spdx-describes-2
branch
from
9c90a4e
to
ec83fa0
Compare
…ships to populate the pUrl. It will fall back to the original method of generating pUrl if neither are available. Added test cases for both of these options. Fixes guacsec#708 Signed-off-by: Anthony LaCross <Anthony.lacross@gmail.com>
CrossedSecurity
force-pushed
the
spdx-describes-2
branch
from
ec83fa0
to
b3c37ac
Compare
pxp928
approved these changes
Jun 29, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ships to populate the pUrl. It will fall back to the original method of generating pUrl if neither are available. Added test cases for both of these options.
Fixes #708
This is a fresh branch for #857
Description of the PR
PR Checklist
-sflag togit commit.make generatehas been runcollectsubprotobuf has been changed,make protohas been run