Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cbase class inheritance #65

Merged
merged 8 commits into from Nov 20, 2015
Merged

Cbase class inheritance #65

merged 8 commits into from Nov 20, 2015

Conversation

sergiopasra
Copy link
Member

This is a rewrite of #63

@sergiopasra sergiopasra added this to the Megara DRP 0.5.x milestone Nov 19, 2015
@sergiopasra
Copy link
Member Author

@Pica4x6 FYI

@sergiopasra sergiopasra self-assigned this Nov 19, 2015
sergiopasra and others added 4 commits November 19, 2015 16:28
@sergiopasra
Organize recipes, do not load recipes in __init__.py
c480c78
@sergiopasra
Split contents of core.py:
a0d22c1 
* "create" goes to test, is a function to create images
* MegaraBaseRecipe goes to core.recipe
* The rest go to core.processing
@sergiopasra
Extend MegaraBaseRecipe
0ce7b59
@sergiopasra
Recipes have been isolated
2130091
@sergiopasra
Copy link
Member Author

@Pica4x6 I think now is complete. The main differences are:

  • MegaraBaseRecipe is still under megaradrp.core
  • MegaraBaseRecipe derives from BaseRecipe, not BaseRecipeAutoQC
  • Module names are lower case, such as megaradrp.recipes.calibration.bias

@sergiopasra
Copy link
Member Author

This PR fixes #52

sergiopasra added a commit that referenced this pull request Nov 20, 2015
@sergiopasra
Merge pull request #65 from sergiopasra/cbase_class_inheritance
34755e3 
Cbase class inheritance
@sergiopasra sergiopasra merged commit 34755e3 into guaix-ucm:master Nov 20, 2015
@sergiopasra sergiopasra deleted the cbase_class_inheritance branch November 20, 2015 10:04
This was referenced Nov 20, 2015
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sergiopasra sergiopasra

Labels
enhancement
Projects
None yet
Milestone
Megara DRP 0.5.x
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sergiopasra