Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global pattern not used for multiple loggers #19

Closed
hramoser opened this issue Apr 9, 2018 · 2 comments
Closed

Global pattern not used for multiple loggers #19

hramoser opened this issue Apr 9, 2018 · 2 comments
Labels
bug

Comments

@hramoser
Copy link
Contributor

hramoser commented Apr 9, 2018

Only the first logger uses global_pattern. Following loggers are assigned an empty pattern.
Reason: global_pattern_opt is moved instead of assigned (conf_impl.h, line 1113).
@guangie88
Copy link
Owner

Hey @hramoser, thanks for spotting this! Do you want to send a PR to fix this? I believe removing the move around global_pattern_opt should fix the issue. Would be better if you get the credit for spotting and fixing this 😃

@guangie88 guangie88 added the bug label Apr 10, 2018
@guangie88
Copy link
Owner

Resolved in #20. Thanks @hramoser for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guangie88 @hramoser