Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-use global_pattern #20

Merged
merged 1 commit into from
Apr 10, 2018
Merged

re-use global_pattern #20

merged 1 commit into from
Apr 10, 2018

Conversation

hramoser
Copy link
Contributor

Do not move global_pattern_opt to allow use for multiple sinks.

@codecov-io
Copy link

codecov-io commented Apr 10, 2018

Codecov Report

Merging #20 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   87.99%   88.01%   +0.02%     
==========================================
  Files           3        3              
  Lines         408      409       +1     
==========================================
+ Hits          359      360       +1     
  Misses         49       49
Impacted Files Coverage Δ
include/spdlog_setup/details/conf_impl.h 89.29% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5ec545...6b1f810. Read the comment docs.

@guangie88
Copy link
Owner

@hramoser Thank you for the PR!

@guangie88 guangie88 merged commit 2606673 into guangie88:master Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants