Add basic ID validation and information extraction.

[whrss9527]

User description

增加了一个除地址信息码之外的基础信息校验和信息提取。
在实际使用中发现，地址码更新会导致实名失败，所以提供一种去除地址码的固定规则校验，不随政策随时变化，更适合企业生产环境使用。

---

Type

Enhancement, Tests

---

Description

• Added a new Go package idvalidator with functions to validate and extract basic ID card information excluding address code.
• Implemented IsValidBasic to validate ID cards based on order code, birthday code, and check bit, excluding address code.
• Implemented GetBasicInfo to extract information such as birthday, sex, and zodiac signs from ID cards.
• Added unit tests to validate the correctness of the ID validation logic and the information extraction functionality.

---

Changes walkthrough

	Relevant files
Enhancement	id_validator_basic.go Implement Basic ID Validation and Information Extraction  id_validator_basic.go Added a new package idvalidator. Implemented IsValidBasic function to validate ID card numbers excluding address code. Implemented GetBasicInfo function to extract basic ID card information excluding address code. Defined BasicIdInfo struct to hold the extracted ID information. +73/-0
Tests	id_validator_basic_test.go Add Tests for Basic ID Validation and Information Extraction id_validator_basic_test.go Added tests for IsValidBasic to ensure it correctly identifies invalid IDs. Added tests for GetBasicInfo to ensure it returns correct results and errors appropriately. +36/-0

---

✨ PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-pro]

PR Description updated to latest commit (af92fea)

• Copy walkthrough table to "Files Changed" Tab

[codiumai-pr-agent-pro]

PR Review

⏱️ Estimated effort to review [1-5]	2, because the PR introduces a new functionality with a moderate amount of code and includes unit tests. The logic is straightforward, focusing on ID validation and information extraction, which is not overly complex.
🧪 Relevant tests	Yes
🔍 Possible issues	Error Handling: The error handling in GetBasicInfo could be improved by providing more specific error messages related to the failure of ID validation.
	Error Propagation: The function generateCode is used in both IsValidBasic and GetBasicInfo but the error from this function is not handled in GetBasicInfo after the initial validity check, which might suppress useful debug information.
	Time Parsing Assumption: The code assumes the system's timezone is set to "Asia/Shanghai" which might not be true for all deployment environments and could lead to incorrect time calculations.
🔒 Security concerns	No

---

✨ Review tool usage guide:

---

Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.

The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

• When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

• With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

See the review usage page for a comprehensive guide on using this tool.

[codiumai-pr-agent-pro]

PR Code Suggestions

Category	Suggestions
Best practice	Add error handling for string to integer conversion. Handle errors returned by strconv.Atoi to prevent runtime panics if the conversion fails. id_validator_basic.go [57] -order, _ := strconv.Atoi(code["order"]) +order, err := strconv.Atoi(code["order"]) +if err != nil { + return BasicIdInfo{}, errors.New("error parsing order from ID") +}
	Handle errors during date parsing to ensure data integrity. Instead of ignoring errors, handle them appropriately to ensure that the birthday parsing does not silently fail. id_validator_basic.go [53] -birthday, _ := time.ParseInLocation("20060102", code["birthdayCode"], cst) +birthday, err := time.ParseInLocation("20060102", code["birthdayCode"], cst) +if err != nil { + return BasicIdInfo{}, errors.New("invalid birthday format") +}
Enhancement	Improve error messages for better debugging and user feedback. Consider using a more specific error message when the ID card number is invalid, to provide more context to the caller. id_validator_basic.go [46] -return BasicIdInfo{}, errors.New("invalid ID card number") +return BasicIdInfo{}, errors.New("invalid ID card number: failed basic validation")
Maintainability	Replace magic strings with constants for clarity and maintainability. Use a constant for the ID type "15" to avoid magic strings and improve code readability. id_validator_basic.go [34] -if code["type"] == "15" { +const fifteenDigitIDType = "15" +if code["type"] == fifteenDigitIDType {
	Refactor function to improve readability and maintainability. Refactor the IsValidBasic function to reduce its complexity by breaking it into smaller, more manageable functions. id_validator_basic.go [22-39] func IsValidBasic(id string) bool { code, err := generateCode(id) if err != nil { return false } - if !checkOrderCode(code["order"]) || !checkBirthdayCode(code["birthdayCode"]) { - return false - } + return isValidOrderAndBirthday(code) && isValidCheckBit(code) +} + +func isValidOrderAndBirthday(code map[string]string) bool { + return checkOrderCode(code["order"]) && checkBirthdayCode(code["birthdayCode"]) +} + +func isValidCheckBit(code map[string]string) bool { if code["type"] == "15" { return true } return code["checkBit"] == generatorCheckBit(code["body"]) }

---

✨ Improve tool usage guide:

---

Overview:
The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

• When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:

/improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...

• With a configuration file, use the following template:

[pr_code_suggestions]
some_config1=...
some_config2=...

See the improve usage page for a comprehensive guide on using this tool.