Workaround for PhantomJS 1.9.8 #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-attempt Conflicts: lib/guard/jasmine/phantomjs/guard-jasmine.js
|
+1 -- build failure though? |
|
Yeah I merged master in as there were some conflicts and it looks like master is failing. |
nathanstitt
added a commit
that referenced
this pull request
Dec 21, 2014
Workaround for PhantomJS 1.9.8
|
Merged, Thank you for your contribution, Dawid |
nathanstitt
added a commit
that referenced
this pull request
Dec 21, 2014
fix from #177 seems to work great, but it only edited the JS, not the original Coffeescript source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
PhantomJS 1.9.8 logs some warning messages to STDOUT and that causes failures when parsing JSON response. Please see ariya/phantomjs#12697 for details. The only workaround that seems to work is to stick
phantom.exitinside asetTimeoutcall.As this is a workaround I'm not sure you'll want to merge this, but as far as I know it's impossible to run
guard-jasminewith PhantomJS 1.9.8 and, from what I see on that issue, they won't be releasing a fix for that in 1.9.x series.