Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all_after_pass: true does not run all specs even if failed one's just passed #233

Closed
dima4p opened this issue Dec 23, 2013 · 6 comments
Closed

Comments

@dima4p
Copy link

dima4p commented Dec 23, 2013

kubuntu 12.04LTS guard (2.2.4) rails (4.0.1) does not run all specs even if failed one's just passed

@dima4p
Copy link
Author

dima4p commented Dec 23, 2013

guard :rspec, all_after_pass: true do
watch(%r{^spec/.+_spec.rb$})
watch(%r{^lib/(.+).rb$}) {|m| "spec/lib/#{m[1]}_spec.rb"}
watch('spec/spec_helper.rb') {"spec"}

Rails example

watch(%r{^app/(.+).rb$}) {|m| "spec/#{m[1]}_spec.rb"}
watch(%r{^app/(.*)(.erb|.haml|.slim|\jbuilder)$}){|m| "spec/#{m[1]}#{m[2]}spec.rb"}
watch(%r{^app/controllers/(.+)
(controller).rb$}) {|m| ["spec/routing/#{m[1]}routing_spec.rb", "spec/#{m[2]}s/#{m[1]}#{m[2]}_spec.rb", "spec/acceptance/#{m[1]}_spec.rb", "spec/requests/#{m[1]}_spec.rb"]}
watch(%r{^app/models/ability.rb$}) {["spec/controllers", "spec/acceptance", "spec/requests"]}
watch(%r{^spec/support/(.+).rb$}) { "spec"}
watch('config/routes.rb') {"spec/routing"}
watch('app/controllers/application_controller.rb') {"spec/controllers"}

Capybara features specs

watch(%r{^app/views/(.+)/.*.(erb|haml|slim)$}) {|m| "spec/features/#{m[1]}_spec.rb"}

Turnip features and steps

watch(%r{^spec/acceptance/(.+).feature$})
watch(%r{^spec/acceptance/steps/(.+)_steps.rb$}) {|m| Dir[File.join("**/#{m[1]}.feature")][0] || 'spec/acceptance'}
end

@907th
Copy link
Contributor

907th commented Dec 24, 2013

Hello, @dima4p! all_after_pass works for me, even with your Guardfile. Could you provide a sample app for this issue? Thanks!

@joefallon
Copy link

I can confirm this issue exists. I am using Mac OSX Mavericks, Rails 4.0.2, Ruby 2.1.0, and a brand new clean application with just a couple of tests.

@907th
Copy link
Contributor

907th commented Jan 1, 2014

@joe-fallon Can you share your app with us and provide steps to reproduce the issue?

@thibaudgg
Copy link
Member

Could you try with Listen 2.7.3, thanks!

@e2
Copy link
Contributor

e2 commented Jun 12, 2015

I'm closing this because it seems old.

If you have problems with the newest version of Guard::RSpec, please open a new issue with an example Guardfile and/or spec file to reproduce if you can.

@e2 e2 closed this as completed Jun 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants