Fix guard notification settings #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
::Bundler.with_clean_env is clobbering the GUARD_NOTIFY and GUARD_NOTIFIERS environment variables needed for notification settings. This change resets guard related environment variables that have been reset by Bundler.
| it "does not clobber GUARD ENV vars" do | ||
| ENV['GUARD_NOTIFY'] = 'true' | ||
| Kernel.should_receive(:system) do | ||
| expect(ENV['GUARD_NOTIFY']).to eq 'true' |
There was a problem hiding this comment.
I'm all ears if you have a suggestion for another way to test the state of ENV vars during the Kernel.system call. I couldn't think of another way to do this...
|
Good! Works for me. That can be considered as a solution until #217 will be accepted |
|
Yeah I think that #217 is a better of fixing it. We'll merge it today hopefully. |
|
Fixed by #217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
::Bundler.with_clean_env is clobbering the
GUARD_NOTIFYandGUARD_NOTIFIERSenvironment variables needed for notification settings. This change resets
guard related environment variables that have been reset by Bundler.
I think this addresses the same issue as #217, although #217 also contains a bunch of refactors.