Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title option #282

Merged
merged 3 commits into from Oct 16, 2014
Merged

Title option #282

merged 3 commits into from Oct 16, 2014

Conversation

dnlgrv
Copy link
Contributor

@dnlgrv dnlgrv commented Aug 19, 2014

Adds a configurable title for notifications. It falls back to 'RSpec results' if one isn't provided.

def notify(summary)
return unless options[:notification]
failure_count, pending_count = _parse_summary(summary)
image = _image(failure_count, pending_count)
priority = _priority(image)
::Guard::Notifier.notify(summary, title: TITLE, image: image, priority: priority)
::Guard::Notifier.notify(summary, title: @options[:title], image: image, priority: priority)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [100/80]

@coveralls
Copy link

Coverage Status

Coverage decreased (-7.98%) when pulling dba1375 on cazrin:title-option into f1e3d91 on guard:master.

@e2
Copy link
Contributor

e2 commented Oct 16, 2014

Thanks!

e2 added a commit that referenced this pull request Oct 16, 2014
@e2 e2 merged commit 073dfa8 into guard:master Oct 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants