-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot set the watch_all_modifications option #173
Comments
Thanks, could you add a failing test (and even fix the issue) and submit a pull-request against the dev branch? |
Thanks for analyzing this issue and reporting it. Your suggestion
works only in the case where the default value is So what can we do? One solution would be to just use the Thor default value and completely remove any default value in the listener itself. This seems fine, but it would lead to a long rat tail to update all methods and its docs to reflect that In the end I simply changed the |
After thinking a second time on this, I simply convert the options keys to symbols before evaluation them. This ensures the projects that are using the Listener framework don't have to change anything. |
In
Guard::Listener
, theinitialize()
method is attempting to set default options:The options hash is an instance of
Thor::CoreExt::HashWithIndifferentAccess
. This hash extension doesn't seem to support indifferent access forfetch()
. Because the stored key is actually a string, this will always default to false.This might be resolved with:
The text was updated successfully, but these errors were encountered: