Readme section for creating new Guard is unclear #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h different meanings in the same context making this section very difficult to understand.
|
Very good catch!! Thanks very much for clarifying all that! :) |
rymai
pushed a commit
that referenced
this pull request
Mar 13, 2012
Readme section for creating new Guard is unclear [ci skip]
|
And you're in the CHANGELOG now! 👏 |
|
Nice. Thanks! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm confused by the use of the term
guard-namein the README section for creating a new guard. It's unclear whether you should be using the actual word "guard" or the name of your Guard.