Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend :tmux notifier with use of tmux display-message and options to configure them #334

Merged
merged 5 commits into from Oct 5, 2012
Merged

Conversation

matthijsgroen
Copy link
Contributor

The current :tmux notifier implementation was too limited that it only colored the left status bar. I want to see a message, so updated the notifier to also use display-message when configured. I has extended configurable options, so 'powerline' users can pimp there messages :-)

@thibaudgg
Copy link
Member

Ok for you @netzpirat? (I don't know/use :tmux)

@netzpirat
Copy link
Contributor

I know but currently don't use tmux, so we have to rely on the experience of @matthijsgroen.

@matthijsgroen
Copy link
Contributor Author

What it basically does (easy to test) when in tmux

tmux display-message 'hello world'

This will show for a short period of time (configurable by tmux set display-time) an message instead of the statusbar. after the period the statusbar returns. this is all standard tmux behaviour, and ideal for notifications such as those of Guard. The user can get the message history by using Ctrl+b ~ (where Ctrl+b is your key to activate tmux).

I think a quick scan of the code will give a general idea what it does.

@netzpirat netzpirat merged commit 00826c4 into guard:master Oct 5, 2012
@netzpirat
Copy link
Contributor

Thanks a lot for your detailed information. I've added it straight to the README.

@matthijsgroen
Copy link
Contributor Author

Ah I'm afraid that is not fully correct, since my code will set that display-time for the user, it overwrites custom settings. I will refork and update the readme in a pull request ok? (sorry for the late response, I was away for the weekend)

@thibaudgg
Copy link
Member

Ok, for the new pull request. Thanks!

@matthijsgroen
Copy link
Contributor Author

When will the rubygem be published on rubygems.org?

@netzpirat
Copy link
Contributor

This has been already published with 1.4.1

@matthijsgroen
Copy link
Contributor Author

hmm weird, rubygems is still listing 1.4.0 as the latest version http://rubygems.org/gems/guard/versions

@netzpirat
Copy link
Contributor

You're right, somehow the "release" wasn't released at all. I reverted the 1.4.1 release commit and will release a new version today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants