Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Longer deprecation message to identify fault #667

Merged
merged 1 commit into from Nov 12, 2014
Merged

Conversation

robert2d
Copy link
Contributor

Recommend extending the deprecation backtrace to make it easy to find faults, as active_supports dependencies is pretty much all you get for 5 lines at the moment.

Example

     >> /Users/dave/.rvm/gems/ruby-2.1.2@phoenix/gems/guard-2.8.2/lib/guard/guard.rb:3:in `<top (required)>'
     >> /Users/dave/.rvm/gems/ruby-2.1.2@phoenix/gems/activesupport-3.2.17/lib/active_support/dependencies.rb:251:in `require'
     >> /Users/dave/.rvm/gems/ruby-2.1.2@phoenix/gems/activesupport-3.2.17/lib/active_support/dependencies.rb:251:in `block in require'
     >> /Users/dave/.rvm/gems/ruby-2.1.2@phoenix/gems/activesupport-3.2.17/lib/active_support/dependencies.rb:236:in `load_dependency'
     >> /Users/dave/.rvm/gems/ruby-2.1.2@phoenix/gems/activesupport-3.2.17/lib/active_support/dependencies.rb:251:in `require'

     >> /Users/dave/.rvm/gems/ruby-2.1.2@phoenix/gems/guard-jasmine-1.17.0/lib/guard/jasmine.rb:4:in `<top (required)>'
     >> /Users/dave/.rvm/gems/ruby-2.1.2@global/gems/bundler-1.6.2/lib/bundler/runtime.rb:85:in `require'

As you can see the stack trace at 5 lines in length is just not enough to expose the culprit.

Thanks

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0%) when pulling d8c6ef5 on robert2d:master into de93bce on guard:master.

e2 added a commit that referenced this pull request Nov 12, 2014
Longer deprecation message to identify fault
@e2 e2 merged commit 7597355 into guard:master Nov 12, 2014
@e2
Copy link
Contributor

e2 commented Nov 12, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants