Merge pull request #383 from guard/fix_state_transition

allow stopping when not fully initialized

lib/listen/listener.rb

@@ -19,6 +19,7 @@
 
 module Listen
   class Listener
+    # TODO: move the state machine's methods private
     include Listen::FSM
 
     # Initializes the directories listener.
@@ -63,11 +64,11 @@ def initialize(*dirs, &block)
 
     state :initializing, to: :backend_started
 
-    state :backend_started, to: [:frontend_ready] do
+    state :backend_started, to: [:frontend_ready, :stopped] do
       backend.start
     end
 
-    state :frontend_ready, to: [:processing_events] do
+    state :frontend_ready, to: [:processing_events, :stopped] do
       processor.setup
     end
 

spec/lib/listen/listener_spec.rb

@@ -140,13 +140,43 @@
       allow(backend).to receive(:start)
       allow(processor).to receive(:setup)
       allow(processor).to receive(:resume)
-      subject.start
     end
 
-    it 'terminates' do
-      allow(backend).to receive(:stop)
-      allow(processor).to receive(:teardown)
-      subject.stop
+    context 'when fully started' do
+      before do
+        subject.start
+      end
+
+      it 'terminates' do
+        allow(backend).to receive(:stop)
+        allow(processor).to receive(:teardown)
+        subject.stop
+      end
+    end
+
+    context 'when frontend is ready' do
+      before do
+        subject.transition :backend_started
+        subject.transition :frontend_ready
+      end
+
+      it 'terminates' do
+        allow(backend).to receive(:stop)
+        allow(processor).to receive(:teardown)
+        subject.stop
+      end
+    end
+
+    context 'when only backend is already started' do
+      before do
+        subject.transition :backend_started
+      end
+
+      it 'terminates' do
+        allow(backend).to receive(:stop)
+        allow(processor).to receive(:teardown)
+        subject.stop
+      end
     end
   end
 
@@ -307,17 +337,4 @@
       end
     end
   end
-
-  describe 'processing changes' do
-    before do
-      allow(backend).to receive(:start)
-    end
-  end
-
-  context 'when listener is stopped' do
-    before do
-      subject.stop
-      allow(silencer).to receive(:silenced?) { true }
-    end
-  end
 end