-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for issue #123 - can force an adapter class #124
fix for issue #123 - can force an adapter class #124
Conversation
is that coveralls thing good or bad? |
oh, ok, do you want tests for that listener.force_adapter method? |
Don't worry about DRY code, I'm currently completely rewrite Listen (for 2.0 release) so I'll take care of that, PS: You can skip Coverage -0% comment :-) |
Just before I merged it, could please update the README as well? Many thanks! |
there you go! Any clues about what's in 2.0? |
Thanks for the README, 2.0 will be based on Celluloid and the DSL will be greatly simplified. I'll push it to https://github.com/guard/listen/tree/v2.0 when the basic will work. More 2.0 related issues here: https://github.com/guard/listen/issues?milestone=2&page=1&state=open |
…pter fix for issue #123 - can force an adapter class
1.2.0 released! |
hah, funny that you mention celluloid - I'm playing with it for my little daemon, too. Will be interested to see the results! |
I updated the v2.0 branch yesterday have a look! (Work in progress) |
Here's my rough and ready solution. There is probably a bit of an opportunity to DRY up the construction of adapters, but I didn't want to step on any toes :)