Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue #123 - can force an adapter class #124

Merged
merged 2 commits into from
Jun 11, 2013

Conversation

nicobrevin
Copy link
Contributor

Here's my rough and ready solution. There is probably a bit of an opportunity to DRY up the construction of adapters, but I didn't want to step on any toes :)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0%) when pulling 1f894e3 on nicobrevin:feature-issue-123-specify-adapter into 067c7c7 on guard:master.

@nicobrevin
Copy link
Contributor Author

is that coveralls thing good or bad?

@nicobrevin
Copy link
Contributor Author

oh, ok, do you want tests for that listener.force_adapter method?

@thibaudgg
Copy link
Member

Don't worry about DRY code, I'm currently completely rewrite Listen (for 2.0 release) so I'll take care of that,
listener.force_adapter will certainly be removed from 2.0 release, so we can also skip specs. Thanks!

PS: You can skip Coverage -0% comment :-)

@thibaudgg
Copy link
Member

Just before I merged it, could please update the README as well? Many thanks!

@nicobrevin
Copy link
Contributor Author

there you go!

Any clues about what's in 2.0?

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling c030fff on nicobrevin:feature-issue-123-specify-adapter into 067c7c7 on guard:master.

@thibaudgg
Copy link
Member

Thanks for the README, 2.0 will be based on Celluloid and the DSL will be greatly simplified. I'll push it to https://github.com/guard/listen/tree/v2.0 when the basic will work. More 2.0 related issues here: https://github.com/guard/listen/issues?milestone=2&page=1&state=open

thibaudgg added a commit that referenced this pull request Jun 11, 2013
…pter

fix for issue #123 - can force an adapter class
@thibaudgg thibaudgg merged commit edb7be2 into guard:master Jun 11, 2013
@thibaudgg
Copy link
Member

1.2.0 released!

@nicobrevin nicobrevin deleted the feature-issue-123-specify-adapter branch June 11, 2013 15:13
@nicobrevin
Copy link
Contributor Author

hah, funny that you mention celluloid - I'm playing with it for my little daemon, too. Will be interested to see the results!

@thibaudgg
Copy link
Member

I updated the v2.0 branch yesterday have a look! (Work in progress)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants