Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest rb-fsevent and rb-notify releases #443

Merged
merged 1 commit into from Jun 2, 2018

Conversation

thibaudgg
Copy link
Member

Latest rb-fsevent release is fixing an annoying issue, I think it would worth forcing the upgrade here.

@thibaudgg thibaudgg self-assigned this Mar 3, 2018
@thibaudgg thibaudgg requested review from rymai and e2 March 3, 2018 19:48
@coveralls
Copy link

coveralls commented Mar 3, 2018

Coverage Status

Coverage decreased (-0.09%) to 97.676% when pulling 2875fb0 on rb-fsevent-upgrade into 46a6adb on master.

@rymai
Copy link
Member

rymai commented Mar 3, 2018

CI doesn't seem to like the change, though... :/

[Latest rb-fsevent release](https://github.com/thibaudgg/rb-fsevent/releases/tag/0.10.3) is fixing an annoying issue, I think it would worth forcing the upgrade here.
@thibaudgg
Copy link
Member Author

Yeah, Travis config seems to be broken here (see #442), @e2 could you please have a look, maybe ruby_dep needs an update?

@junaruga
Copy link
Contributor

junaruga commented Jun 1, 2018

@e2 I think at least this PR improves current situation.

Current master
https://travis-ci.org/guard/listen/builds/248699966

It is better to merge isn't it?
Then we can change rbx-2 to rbx-3, and add Ruby 2.5 in other PRs, and check jruby issue etc.

@rymai
Copy link
Member

rymai commented Jun 2, 2018

@junaruga Sounds good!

@rymai rymai merged commit daac99d into master Jun 2, 2018
@rymai rymai deleted the rb-fsevent-upgrade branch June 2, 2018 11:58
@junaruga
Copy link
Contributor

junaruga commented Jun 2, 2018

@rymai thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants