Update dependencies and travis matrix #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rymai
commented
Jun 4, 2018
rymai
commented
- 38108c5 2018-06-03 | Replace jruby-9.1.2.0 by jruby-9.2.0.0 in the build matrix [Olle Jonsson]
- 913c166 2018-06-04 | Simplify the build matrix to use minor Ruby versions [Rémy Coutable]
- 736dd9c 2017-12-31 | Add Ruby 2.5.0 to the build matrix [Tsukuru Tanimichi]
- 1161552 2016-06-05 | Replace rbx-2 with rbx-3 in the build matrix [Omer Katz]
- 45802c5 2018-06-04 | Don't use RubyDep anymore since it's outdated and not very useful [Rémy Coutable]
houndci-bot
reviewed
Jun 4, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming Error: The `Style/TrailingCommaInLiteral` cop no longer exists. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in .rubocop.yml `Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
This was referenced Jun 4, 2018
Closed
Closed
Signed-off-by: Rémy Coutable <remy@rymai.me>
Signed-off-by: Rémy Coutable <remy@rymai.me>
Signed-off-by: Rémy Coutable <remy@rymai.me>
Signed-off-by: Rémy Coutable <remy@rymai.me>
Signed-off-by: Rémy Coutable <remy@rymai.me>
Signed-off-by: Rémy Coutable <remy@rymai.me>
rymai
force-pushed
the
update-dependencies-and-travis-matrix
branch
from
38108c5
to
648c64f
Compare
|
@rymai thanks for the PR! https://travis-ci.org/guard/listen/builds/387684506?utm_source=github_status&utm_medium=notification Ruby 2.4 -> error by But it looks good to me. I think this PR improves current master branch. https://rubygems.org/gems/simplecov |
|
Someone cared to PR the coveralls gem: |
tnir
added a commit
to tnir/rails_sample_app
that referenced
this pull request
May 19, 2021
See guard/listen#446 and guard/listen#490 Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.