-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #450: linux driver: add :modify to default events listened to #502
issue #450: linux driver: add :modify to default events listened to #502
Conversation
@ms-ati brought up the risk that adding That PR is all using stubs, so it doesn't disprove the possibility of duplicate events. I can try running an interactive test to see if that happens. |
@ms-ati I ran this test on a Linux pod. It worked perfectly--no dups!
|
@ColinDKelley Awesome! Could you try editing a file and saving it, as opposed to running |
(that is -- not simply appending -- but editing and saving) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Pending manual interactive test of editing and saving a file if possible
@ms-ati I ran that test on a Linux pod and it worked exactly as expected. I tried both editing an existing file, and a new one.
|
BTW, I've added a variant of the above tests to the README since they seem helpful to understand how it works overall. |
cc @ioquatix looks like this PR is pending your formal review in Github? |
I'm going to merge and release as v3.3.0.pre.3 so we can get some burn-in time. I'm still interested in your review though, @ioquatix! |
Fix for issue #450 .