make java 21 the default for snyk workflow #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnduffell
changed the title
|
Myself and @johnduffell have spoken about this and we decided that this change is too risky with an unversioned action. We can revisit it once we have semver releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that java 11 is the default, but now our recommendation is java 21 (although java 11 is still acceptable as a minumim) see https://docs.google.com/document/d/1ZR-YnaXCT5_gLVmTCeGs0mWd3KPaAozPjQK8uUzHZ9w/edit#heading=h.gnp9lqaztaf . I noticed this when we were doing this PR guardian/support-service-lambdas#2218
This might break some older projects? But scala-steward uses java 21 - guardian/scala-steward-public-repos#67 (although check how many comments further down mention issues!) , so we could prompt it (especially given the perf improvements of java 21 over 11)
Happy to go either way on this PR, we can be bold and merge it (with comms?) or be cautious, since breaking snyk checks can cause the checks to stop, without it being totally obvious.