Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Use testId in place of passing the whole test object #12

Merged
merged 1 commit into from Jun 15, 2020
Merged

Use testId in place of passing the whole test object #12

merged 1 commit into from Jun 15, 2020

Conversation

oliverlloyd
Copy link
Contributor

What does this change?

We only ever use the id from the test object so here we refactor to only require that in isUserInVariant()

const isUserInVariant: CoreAPI['isUserInVariant'] = (testId, variantId)

@oliverlloyd
Copy link
Contributor Author

AB - testid instead of test

@oliverlloyd oliverlloyd mentioned this pull request Jun 15, 2020
Closed
gtrufitt
gtrufitt approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@gtrufitt gtrufitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer!

@oliverlloyd oliverlloyd merged commit ec2a747 into master Jun 15, 2020
@mxdvl mxdvl deleted the oliver/use-variant-id branch June 25, 2021 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gtrufitt gtrufitt gtrufitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oliverlloyd @gtrufitt