RFC: Signed RiffRaff Artifacts #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshCorr
force-pushed
the
ash/hashes
branch
7 times, most recently
from
e4e696a
to
be3b06c
Compare
AshCorr
changed the title
|
This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days |
|
not yet! |
|
This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days |
|
This PR was closed because it has been stalled for 3 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
In addition to a
build.jsonfileactions-riff-raffwill also produce asigstore-hashes.jsonfile which lists all of the SHA256 file hashes of the files being uploaded to riff-raff.sigstore-hashes.jsonis signed using Sigstore. This allows riff-raff to verify that thesigstore-hashes.jsonfile has been created by a workflow in the Guardian organisation, and perhaps eventually that the repository uploading the artifact has access to the project being deployed to.In the short term we can get riff-raff to add a warning to any builds that don't have a sigstore-hashes.json file and/or have files that have been tampered with, but eventually, once adoption is high enough, fail builds that don't have an attached
sigstore-hashes.jsonfile.How to test
How can we measure success?
Have we considered potential risks?
Images
Accessibility