-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Replace sources
with contentDirectories
#18
Conversation
a3f97f6
to
7720698
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have left some thoughts on testing especially - as would be keen for us to avoid the test-utils
approach here. But in terms of feature-set this is great!
8b1a09a
to
f9c2505
Compare
contentDirectories
inputsources
with contentDirectories
f9c2505
to
6ebf33a
Compare
Fixes #13. In this change we remove support for `sources` in the body of the `riff-raff.yaml` config, and replace it with a `contentDirectories` input to the Action. This decoupling keeps the `riff-raff.yaml` config "valid". That is, we're able to copy/paste it into Riff-Raff's validation tool w/out first needing to remove `sources`. It also means this action becomes compatible with auto-generated `riff-raff.yaml` files. BREAKING CHANGE: `sources` within `riff-raff.yaml` (either via the `config` or `configPath` input) is no longer supported Configure the files to upload via the `contentDirectories` input, where `contentDirectories` is a mapping of package name -> artifact files. From: ```yaml - uses: guardian/actions-riff-raff@v1 with: app: my-application config: | stacks: - deploy regions: - eu-west-1 allowedStages: - CODE - PROD deployments: static-site-assets: type: aws-s3 sources: - static-site/dist # upload the `dist` directory parameters: bucket: aws-some-bucket cacheControl: private publicReadAcl: false api: type: autoscaling sources: - target/application.jar parameters: bucketSsmLookup: true ``` To: ```yaml - uses: guardian/actions-riff-raff@v2 # Note the version change with: app: my-application config: | stacks: - deploy regions: - eu-west-1 allowedStages: - CODE - PROD deployments: static-site-assets: # <-- this is a package name type: aws-s3 parameters: bucket: aws-some-bucket cacheControl: private publicReadAcl: false api: # <-- this is another package name type: autoscaling parameters: bucketSsmLookup: true contentDirectories: | static-site-assets: - static-site/dist api: - target/application.jar ```
6ebf33a
to
bdf5504
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm tempted to attempt a slight shortening of the README as a follow up but this is a big improvement on things as it stands.
Fixes #13.
What does this change?
In this change we remove support for
sources
in the body of theriff-raff.yaml
config, and replace it with acontentDirectories
input to the Action.This decoupling keeps the
riff-raff.yaml
config "valid". That is, we're able to copy/paste it to Riff-Raff's validation tool w/out first needing to removesources
.It also means this action becomes compatible with auto-generated
riff-raff.yaml
files.sources
withinriff-raff.yaml
(either via theconfig
orconfigPath
input) is no longer supportedConfigure the files to upload via the
contentDirectories
input, wherecontentDirectories
is a mapping of package name -> artifact files.From:
To:
How to test
See: