Record build tool #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help us track (in Riffraff) which projects are built using this tool.
nicl
force-pushed
the
nicl/record-build-tool
branch
from
788b9c0
to
37bc7e1
Compare
This was referenced Dec 1, 2022
kenoir
reviewed
Dec 2, 2022
| @@ -8,7 +8,11 @@ import type { Deployment } from './riffraff'; | |||
| import { manifest, riffraffPrefix } from './riffraff'; | |||
| import { S3Store, sync } from './s3'; | |||
|
|
|||
| export const main = async (): Promise<void> => { | |||
| interface Options { | |||
| WithSummary: boolean; // Use to disable summary when running locally. | |||
There was a problem hiding this comment.
Is this simply to de-clutter test output?
There was a problem hiding this comment.
Ah ... it's to stop the summary appearing in GitHub checks in PRs here where it doesn't make sense. 👍
There was a problem hiding this comment.
The test was actually broken (when run locally) by #20 but went unnoticed. The summary requires a GITHUB env var + file to be present, which is hard to stub locally.
kenoir
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help us track (in Riffraff) which projects are built using this tool.