feat: Support repositories with multiple Riff-Raff projects #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the project name to uniquely identify PR comments.
akash1810
force-pushed
the
aa/support-mono-repo
branch
from
3578346
to
fb4579c
Compare
twrichards
approved these changes
Nov 24, 2023
akash1810
added a commit
that referenced
this pull request
Dec 18, 2023
In #88 started creating multiple comments. Currently, we're only updating the first comment found that the action previously authored (via `.find`). This change updates all comments that this action previouslt authored (via `.filter`).
akash1810
added a commit
that referenced
this pull request
Dec 18, 2023
In #88 started creating multiple comments. Currently, we're only updating the first comment found that the action previously authored (via `.find`). This change updates all comments that this action previouslt authored (via `.filter`).
akash1810
added a commit
that referenced
this pull request
Dec 18, 2023
In #88 started creating multiple comments. Currently, we're only updating the first comment found that the action previously authored (via `.find`). This change updates all comments that this action previously authored (via `.filter`).
akash1810
added a commit
that referenced
this pull request
Dec 18, 2023
In #88 started creating multiple comments. Currently, we're only updating the first comment found that the action previously authored (via `.find`). This change updates all comments that this action previously authored (via `.filter`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Use the project name to uniquely identify PR comments. This should provide support for repositories that hold multiple Riff-Raff projects, yielding a PR comment for each individual Riff-Raff project.
Note, as the way we're identifying previous comments is changing, we might see double comments for a short while.
❓ Is it be better to have a single comment, with more links? Or multiple comments, with fewer links?
How to test
See https://github.com/guardian/editorial-tools-platform/pull/719.
How can we measure success?
More use-cases are supported.