Skip to content

Commit

Permalink
Delete customer by ID not name
Browse files Browse the repository at this point in the history
  • Loading branch information
satterly committed Jan 2, 2017
1 parent df8ce5b commit 296d1af
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion alerta/app/database/mongo.py
Original file line number Diff line number Diff line change
Expand Up @@ -1363,7 +1363,7 @@ def get_customers(self, query=None):

def delete_customer(self, customer):

response = self.db.customers.delete_one({"customer": customer})
response = self.db.customers.delete_one({"_id": customer})
return True if response.deleted_count == 1 else False

def get_keys(self, query=None):
Expand Down
5 changes: 4 additions & 1 deletion tests/test_auth.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,9 @@ def test_login(self):
}
response = self.app.post('/customer', data=json.dumps(payload), headers=self.headers)
self.assertEqual(response.status_code, 201)
data = json.loads(response.data.decode('utf-8'))

customer_id = data['id']

payload = {
'email': 'josephine@debeauharnais.fr',
Expand Down Expand Up @@ -203,5 +206,5 @@ def test_login(self):
self.assertEqual(response.status_code, 200)

# delete customer mapping
response = self.app.delete('/customer/' + 'Bonaparte Industries', headers=self.headers)
response = self.app.delete('/customer/' + customer_id, headers=self.headers)
self.assertEqual(response.status_code, 200)

0 comments on commit 296d1af

Please sign in to comment.