feat(hangouts): Threading! #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akash1810
force-pushed
the
aa/threading
branch
from
a905eeb
to
9dd613b
Compare
Add support for threaded messages in Hangouts. This is useful when multiple messages are sent in quick succession from the same app, for example RepoCop. The additional field is optional, so should be backwards compatible.
akash1810
force-pushed
the
aa/threading
branch
from
9dd613b
to
2112057
Compare
akash1810
commented
Nov 1, 2023
| @@ -46,7 +47,8 @@ case class Notification( | |||
| actions: List[Action], | |||
| target: List[Target], | |||
| channel: RequestedChannel, | |||
| sourceSystem: String | |||
| sourceSystem: String, | |||
| threadKey: Option[String] // only used for Hangouts messages | |||
There was a problem hiding this comment.
This Notification case class is the contract between Anghammarad and users. Adding the additional field as an Option should mean this change is backwards compatible.
There was a problem hiding this comment.
Minor: we could default this to None?
There was a problem hiding this comment.
Ah yes! I hadn't set a default value so I could see all the compiler warnings. Can safely set one now though.
|
This has been released now in v1.8.1 of the Scala plugin, and v1.1.0 in the NPM module. EDIT: I've unpublished v1.1.0 from NPM, and released this change as v1.8.1 instead - https://www.npmjs.com/package/@guardian/anghammarad?activeTab=versions. We haven't followed semver here, but the version numbers align at least. |
akash1810
added a commit
to guardian/service-catalogue
that referenced
this pull request
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Add support for threaded messages in Hangouts. This is useful when multiple messages are sent in quick succession from the same app, for example RepoCop. Threading messages together, hopefully, reduces the sense of spam/noise.
This change requires a new version of the libraries to be published. The additional field is optional, so should be backwards compatible for clients using older versions of the libraries.
How to test
Run the "dev" project locally and observe threaded messages: