Fix json conversion #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamnfish
reviewed
Apr 4, 2018
| } | ||
| "produces valid JSON for all" in { | ||
| targetJson(List(Stack("stack"), Stage("stage"), App("app"), AwsAccount("123456789"))) shouldEqual | ||
| """{"Stack":"stack","Stage":"stage","App":"app","AwsAccount":"123456789"}""" |
There was a problem hiding this comment.
I was thinking about making the project depend on circe for tests. We could parse the resulting JSON and inspect the keys, rather than check it as a string. This would also allow a test for "this actually parses" which would have value itself.
There was a problem hiding this comment.
(the issue here is that the test passing is coupled to the order of a data structure that is technically "unordered")
There was a problem hiding this comment.
(I know this isn't the only place where this happens and happy for that to be a separate change in a bit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct construction of "target" field in json output. It needs to be an object containing zero or more target fields, not a string.