Move to multi-project build and make it riff-raff deployable #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamnfish
approved these changes
Mar 22, 2018
| @@ -1 +1,5 @@ | |||
| addSbtPlugin("com.typesafe.sbt" % "sbt-native-packager" % "1.2.2") | |||
|
|
|||
There was a problem hiding this comment.
Do we still need native packager now the build has changed?
| lazy val `client-lib` = project | ||
| .settings( | ||
| name := "client-lib", | ||
| libraryDependencies ++= dependencies, |
There was a problem hiding this comment.
This is fine for now, but I suspect the dependencies will differ.
(client lib won't need AWS features apart from SNS, shouldn't include logging (might conflict with other people's loggers) and won't need a markdown parser)
Conflicts: anghammarad/src/test/scala/com/gu/anghammarad/ContactsTest.scala
adamnfish
force-pushed
the
jw-riff-raff-deploys
branch
from
97ccf51
to
b460f18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussing with @adamnfish, we decided to use a multi-project build so that we can have a client-library in this repo at a later date. I've tweaked build.sbt accordingly, and have also added the necessary plugins to create a .jar with sbt assembly and deploy the project with riff-raff.
I've also added a basic riff-raff.yaml which deploys the lambda.
I tried to use riff-raff to run cloudformation updates too, but this was failing (I think due to the SAM transform?), so I will dig around a bit more and add this back in later (i.e. in a different PR) if possible.
Also to-do: