Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to play 2.7 #63

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Upgrade to play 2.7 #63

merged 2 commits into from
Nov 15, 2022

Conversation

davidfurey
Copy link
Member

What does this change?

Attempts to make minimum changes necessary to upgrade library to use Play 2.7 and remove warnings.

This will allows us to upgrade these projects to Play 2.7:

@davidfurey davidfurey requested a review from a team May 17, 2022 10:06
Copy link
Contributor

@jonathonherbert jonathonherbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build passes, LGTM. Has this been tested locally with a snapshot? Happy to test in this way if that's not the case.

@davidfurey
Copy link
Member Author

Not yet, but I will publish a snapshot and start work on another Play 2.7 upgrade before merging

davidfurey and others added 2 commits November 9, 2022 14:44
I get runtime exceptions when using at play 2.7.0, but things run fine at 2.7.9
@andrew-nowak
Copy link
Member

andrew-nowak commented Nov 9, 2022

tested with MAM 2.7 upgrade guardian/media-atom-maker#1071
with the caveat that I bumped all the way to 2.7.9 - I got runtime errors about missing methods at 2.7.0, so I decided to bump to the latest version to get all available bugfixes

@andrew-nowak andrew-nowak merged commit 6c1bdcf into main Nov 15, 2022
@andrew-nowak andrew-nowak deleted the play-2.7-upgrade branch November 15, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants