Adopt GHA Scala Library Release Workflow #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
force-pushed
the
adopt-gha-scala-library-release-workflow
branch
from
0539bd6
to
12b92a8
Compare
Here we're switching from using `actions-sbt-release` to `gha-scala-library-release-workflow` for publishing releases of this library - see also guardian/actions-sbt-release#1. A fair bit of sbt configuration is deleted or changed - see the docs on config changes for more information: https://github.com/guardian/gha-scala-library-release-workflow/blob/main/docs/configuration.md Once this PR is merged, we should also delete the old repository secrets: https://github.com/guardian/atom-maker/settings/secrets/actions
rtyley
force-pushed
the
adopt-gha-scala-library-release-workflow
branch
from
12b92a8
to
1eebbe5
Compare
rebecca-thompson
approved these changes
Jan 17, 2024
rtyley
added a commit
that referenced
this pull request
Jan 17, 2024
After #93 we found that unfortunately the Release workflow failed while running the tests: * The Release workflow uses Java 17 for all builds * The Atom Maker library uses Play with Guice for Dependency Injection * Guice gained Java 17 & 21 support with Guice v6: https://github.com/google/guice/wiki/Guice600 * Play only updated to Guice v6 (and gained general Java 17 support) with Play v2.9: playframework/playframework#11808 playframework/playframework@10ca54d#diff-3dc52110c1c1c453c2e9740ac58fe7e90d53121875a034ef3109c34ab030c29e
rtyley
added a commit
that referenced
this pull request
Jan 17, 2024
After #93 we found that unfortunately the Release workflow failed while running the tests: * The Release workflow uses Java 17 for all builds * The Atom Maker library uses Play with Guice for Dependency Injection * Guice gained Java 17 & 21 support with Guice v6: https://github.com/google/guice/wiki/Guice600 * Play only updated to Guice v6 (and gained general Java 17 support) with Play v2.9: playframework/playframework#11808 playframework/playframework@10ca54d#diff-3dc52110c1c1c453c2e9740ac58fe7e90d53121875a034ef3109c34ab030c29e
rtyley
added a commit
that referenced
this pull request
Jan 18, 2024
After #93 we found that unfortunately the Release workflow failed while running the tests: * The Release workflow uses Java 17 for all builds * The Atom Maker library uses Play with Guice for Dependency Injection * Guice gained Java 17 & 21 support with Guice v6: https://github.com/google/guice/wiki/Guice600 * Play only updated to Guice v6 (and gained general Java 17 support) with Play v2.9: playframework/playframework#11808 playframework/playframework@10ca54d#diff-3dc52110c1c1c453c2e9740ac58fe7e90d53121875a034ef3109c34ab030c29e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we're switching from using
actions-sbt-releasetogha-scala-library-release-workflowfor publishing releases of this library - see also guardian/actions-sbt-release#1 for details on why we want to make this move.A fair bit of sbt configuration is deleted or changed - see the docs on config changes for more information, and enjoy the decreased line-count! ✨
I'd be very happy to pair with anyone who wants to walk through this PR or try out the release process for themselves - please do let me know if you've got any questions!
Once this PR is merged, we should also delete the old repository secrets: