Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependency kinesis-logback-appender #347

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

davidfurey
Copy link
Member

This library is not used and is deprecated. Removing this dependency revealed that aws-java-sdk-sts and aws-java-sdk-inesis are required but only included via kinesis-logback-appender

At the same time, I've removed a key that SBT warned was unused.

This library is not used and is deprecated. Removing this dependency revealed that aws-java-sdk-sts and aws-java-sdk-kinesis are required but only included via kinesis-logback-appender
@davidfurey davidfurey requested a review from a team November 24, 2023 17:18
Copy link

@simonbyford simonbyford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidfurey davidfurey merged commit 4e25b67 into main Dec 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants