Bump @guardian/* packages
#474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this results in a major dependency change, due to the fact that these change the peer dependencies range.
🦋 Changeset detectedLatest commit: 31348ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mxdvl
force-pushed
the
mxdvl/dependencies/bump-guardian-packages
branch
from
385ed0f
to
4757aa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
@guardian/source-react-componentstov22.1.0@guardian/source-react-components-development-kitchentov19.0.0This is a major change as per our recommendations, and consumers should ensure that they provide a compatible version of the package.
How to test
Not sure, left as an exercise to the team
How can we measure success?
Stop having mismatched peer dependencies in
dotcom-rendering$ pnpm install --resolution-only dotcom-rendering ├─┬ @guardian/braze-components 18.1.0 │ ├── ✕ unmet peer @guardian/source-react-components@^18.0.0: found 22.0.1 │ └── ✕ unmet peer @guardian/source-react-components-development-kitchen@^16.0.0: found 19.0.0 ├─┬ @guardian/browserslist-config 6.1.0 │ └── ✕ unmet peer browserslist@^4.22.2: found 4.21.9 ├─┬ @guardian/commercial 17.12.0 │ └── ✕ unmet peer @guardian/support-dotcom-components@^1.0.7: found 2.1.0 └─┬ @storybook/react-webpack5 7.6.17 └─┬ @storybook/preset-react-webpack 7.6.17 └─┬ @pmmmwh/react-refresh-webpack-plugin 0.5.11 └── ✕ unmet peer webpack-dev-server@"3.x || 4.x": found 5.0.4Have we considered potential risks?
No – please advise