Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chromatic action #480

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Fix Chromatic action #480

merged 4 commits into from
Jun 6, 2024

Conversation

tjmw
Copy link
Member

@tjmw tjmw commented Jun 5, 2024

What does this change?

I've started seeing errors for the Chromatic action:

error @guardian/braze-components@20.0.0: The engine "node" is incompatible with this module. Expected version "^18.15 || ^20.9". Got "20.8.1"

It seems that the Chromatic action does its own thing with regards to the Node version it uses. The version provided by the setup-node action isn't honoured by Chromatic. Even so, I've moved to using the standard setup-node action and away from the deprecated Guardian setup Node action.

I've slightly loosened the Node version string under engines in package.json, to reflect the version Chromatic seems to be using. This is the real fix to get things working.

Also bump the Chromatic action, which was way behind.

How to test

How can we measure success?

Have we considered potential risks?

Images

Accessibility

tjmw added 2 commits June 5, 2024 16:26
This is how the main build works. I've started seeing errors for this
action:
error @guardian/braze-components@20.0.0: The engine "node" is incompatible with this module. Expected version "^18.15 || ^20.9". Got "20.8.1"

I'm hoping this will fix things.
Copy link

changeset-bot bot commented Jun 5, 2024

⚠️ No Changeset found

Latest commit: 56afc08

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tjmw tjmw marked this pull request as ready for review June 5, 2024 16:09
Copy link
Contributor

@rBangay rBangay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tjmw tjmw merged commit 97b548f into main Jun 6, 2024
7 checks passed
@tjmw tjmw deleted the tw/fix-chromatic branch June 6, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants