Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
I've started seeing errors for the Chromatic action:
error @guardian/braze-components@20.0.0: The engine "node" is incompatible with this module. Expected version "^18.15 || ^20.9". Got "20.8.1"
It seems that the Chromatic action does its own thing with regards to the Node version it uses. The version provided by the setup-node action isn't honoured by Chromatic. Even so, I've moved to using the standard setup-node action and away from the deprecated Guardian setup Node action.
I've slightly loosened the Node version string under
engines
in package.json, to reflect the version Chromatic seems to be using. This is the real fix to get things working.Also bump the Chromatic action, which was way behind.
How to test
How can we measure success?
Have we considered potential risks?
Images
Accessibility