Prepare the code to remove GA

guardian · May 20, 2024 · fcbad5e · fcbad5e
1 parent 901e31f
commit fcbad5e
Show file tree

Hide file tree

Showing 10 changed files with 0 additions and 239 deletions.
diff --git a/package.json b/package.json
@@ -59,7 +59,6 @@
 		"@guardian/prettier": "4.0.0",
 		"@guardian/source-foundations": "14.1.4",
 		"@playwright/test": "1.40.1",
-		"@types/google.analytics": "^0.0.42",
 		"@types/googletag": "~3.1.3",
 		"@types/jest": "^29.4.0",
 		"@types/lodash-es": "^4.17.6",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/core/event-timer.spec.ts b/src/core/event-timer.spec.ts
@@ -81,11 +81,6 @@ describe('EventTimer', () => {
 		window.guardian = {
 			config: {
 				...DEFAULT_CONFIG,
-				googleAnalytics: {
-					trackers: {
-						editorial: 'gaTrackerTest',
-					},
-				},
 			},
 		} as typeof window.guardian;
 

diff --git a/src/core/messenger/click.spec.ts b/src/core/messenger/click.spec.ts
diff --git a/src/core/messenger/click.ts b/src/core/messenger/click.ts
diff --git a/src/core/types.ts b/src/core/types.ts
@@ -36,14 +36,9 @@ export type ThirdPartyTag = {
 
 export type GetThirdPartyTag = (arg0: { shouldRun: boolean }) => ThirdPartyTag;
 
-export type GuardianAnalyticsConfig = {
-	trackers: Record<string, string>;
-};
-
 export type Edition = 'UK' | 'AU' | 'US';
 
 export type GuardianWindowConfig = {
-	googleAnalytics?: GuardianAnalyticsConfig;
 	isDotcomRendering: boolean;
 	ophan: {
 		// somewhat redundant with guardian.ophan

diff --git a/src/init/consented/messenger.ts b/src/init/consented/messenger.ts
@@ -1,6 +1,5 @@
 import { initMessenger } from 'core';
 import { init as background } from 'core/messenger/background';
-import { init as sendClick } from 'core/messenger/click';
 import { init as disableRefresh } from 'core/messenger/disable-refresh';
 import { init as fullwidth } from 'core/messenger/full-width';
 import { init as initGetPageTargeting } from 'core/messenger/get-page-targeting';
@@ -28,7 +27,6 @@ initMessenger(
 		passbackRefresh,
 		resize,
 		fullwidth,
-		sendClick,
 		background,
 		disableRefresh,
 		passback,

diff --git a/src/init/consented/prepare-googletag.spec.ts b/src/init/consented/prepare-googletag.spec.ts
@@ -71,7 +71,6 @@ jest.mock('lib/detect/detect-breakpoint', () => ({
 	getCurrentBreakpoint: jest.fn(),
 	hasCrossedBreakpoint: jest.fn(),
 }));
-jest.mock('lib/analytics/google', () => () => void {});
 jest.mock('display/display-lazy-ads', () => ({
 	displayLazyAds: jest.fn(),
 }));

diff --git a/src/lib/analytics/google.ts b/src/lib/analytics/google.ts
diff --git a/src/types/global.ts b/src/types/global.ts
@@ -146,12 +146,6 @@ interface PageConfig extends CommercialPageConfig {
 
 interface Config {
 	frontendAssetsFullURL?: string;
-	googleAnalytics?: {
-		timingEvents?: GoogleTimingEvent[];
-		trackers?: {
-			editorial?: string;
-		};
-	};
 	isDotcomRendering: boolean;
 	ophan: {
 		// somewhat redundant with guardian.ophan
@@ -501,7 +495,6 @@ declare global {
 		nol_t: (pvar: { cid: string; content: string; server: string }) => Trac;
 
 		// Google
-		ga?: UniversalAnalytics.ga | null;
 		google_trackConversion?: (arg0: GoogleTrackConversionObject) => void;
 		google_tag_params?: GoogleTagParams;