Refresh page on consent change #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8e0a65c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
emma-imber
added
the
[beta] @guardian/commercial
|
🚀 0.0.0-beta-20240124105308 published to npm as a beta release |
emma-imber
added
[beta] @guardian/commercial
|
🚀 0.0.0-beta-20240124125623 published to npm as a beta release |
emma-imber
force-pushed
the
ei/refresh-page-on-consent-change
branch
3 times, most recently
from
78e0d03
to
d63455b
Compare
emma-imber
added
[beta] @guardian/commercial
|
🚀 0.0.0-beta-20240208122858 published to npm as a beta release |
emma-imber
force-pushed
the
ei/refresh-page-on-consent-change
branch
from
5e05d5a
to
2759d28
Compare
emma-imber
added
[beta] @guardian/commercial
|
🚀 0.0.0-beta-20240213111558 published to npm as a beta release |
emma-imber
force-pushed
the
ei/refresh-page-on-consent-change
branch
from
46e4595
to
8f2390f
Compare
emma-imber
force-pushed
the
ei/refresh-page-on-consent-change
branch
from
8f2390f
to
051a7f4
Compare
emma-imber
added
[beta] @guardian/commercial
|
🚀 0.0.0-beta-20240227165933 published to npm as a beta release |
emma-imber
removed
the
[beta] @guardian/commercial
arelra
reviewed
Mar 4, 2024
| }, true); | ||
| }; | ||
|
|
||
| const reloadPageOnConsentChange = once(() => |
There was a problem hiding this comment.
Not sure why we need to once() as I thought we would only call this in the boot script?
There was a problem hiding this comment.
Good spot - I think this is from the original PR back in frontend. I've removed it and seems to work fine without!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a module to refresh the page when consent state changes, and an E2E test to wait for a page reload when consent state changes.
Also deletes the module to remove consented ads on consent withdrawal, as we no longer need this if we're refreshing the page immediately.
Why?
This means our data will correctly reflect the page consent status, and that users will immediately experience the appropriate ad experience on consent change.