Check global and custom vendor for Prebid #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6ec7907 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Should be able to enable the playwright test again in this PR too right? |
arelra
added
the
[beta] @guardian/commercial
|
🚀 0.0.0-beta-20240209125551 published to npm as a beta release |
arelra
force-pushed
the
ravi/prebid-dual-vendors
branch
from
5aa20c6
to
40038c5
Compare
|
🚀 0.0.0-beta-20240209141457 published to npm as a beta release |
arelra
added
[beta] @guardian/commercial
|
🚀 0.0.0-beta-20240209161454 published to npm as a beta release |
Co-authored-by: Akinsola Lawanson <106528085+akinsola-guardian@users.noreply.github.com>
arelra
force-pushed
the
ravi/prebid-dual-vendors
branch
from
9f00147
to
d3cb55f
Compare
This brings in the new custom Prebid vendor Co-authored-by: Akinsola Lawanson <106528085+akinsola-guardian@users.noreply.github.com>
arelra
force-pushed
the
ravi/prebid-dual-vendors
branch
from
d3cb55f
to
6ec7907
Compare
emma-imber
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
The TCF global Prebid vendor has been dropped from Sourcepoint which means Prebid header bidding is failing for newly consented users in TCF.
This PR adds an additional check for consent for the new custom Prebid vendor so that we maintain consent for existing consented users and newly consented users.
If the user does not consent to either vendor Prebid will not load.
CMP update here: guardian/consent-management-platform#921