Move im below inline1
#1360
Merged
Move im below inline1
#1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cf284fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
deedeeh
added
[beta] @guardian/commercial
|
🚀 0.0.0-beta-20240502131530 published to npm as a beta release |
deedeeh
added
the
[beta] @guardian/commercial
|
🚀 0.0.0-beta-20240502135404 published to npm as a beta release |
i-hardy
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR changes the order of the
imandinline1slots so now we have theimbelowinline1.Occasionally
hasInlineMerchwill be true but won't serve, due to unsupported targeting being added to the line items, this causesinline1to be lower than it should be cause it will still try to avoidim.inline1is our most valuable slot so changing the order seemed like the best way to avoid thisimissue.This change is tested locally and in CODE with this article using Spacefinder debug which you can use by adding
?sfdebugat the end of the url.Why?
Reduce revenue impact when the above
imissue occurs.Screenshots