Increase spacefinder mobile minAbove distance by 100px #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 85abe14 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Jakeii
approved these changes
May 17, 2024
arelra
force-pushed
the
ravi/increase-inline1-distance-from-top
branch
from
475f0d8
to
85abe14
Compare
arelra
changed the title
ashishpuliyel
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the first mobile ad down the article slightly
Why?
The current rule specifies the first ad can appear 100px from the top of the article. This means that sometimes the first ad appears after the opening sentence/paragraph, and this has raised concerns within the editorial team.
Increasing the rule to 200px should mean that the at least a couple of sentences are included before the first ad on mobile.
Testing suggests the issue is not as common on desktop (where the rule is 300px).