Prepare code to remove GA from Web and AMP #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 93a57e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
arelra
force-pushed
the
dina/prepare-code-to-remove-ga
branch
from
b0feadc
to
c300403
Compare
deedeeh
commented
May 24, 2024
This was referenced May 31, 2024
deedeeh
added
the
[beta] @guardian/commercial
|
🚀 0.0.0-beta-20240603085241 published to npm as a beta release |
SiAdcock
reviewed
Jun 6, 2024
| } | ||
| const navigationEvents = performance.getEntriesByType('navigation'); | ||
| const lastNavigationEvent = navigationEvents[navigationEvents.length - 1]; | ||
| return lastNavigationEvent?.type; | ||
| // https://developer.mozilla.org/en-US/docs/Web/API/PerformanceEntry/entryType#navigation | ||
| return lastNavigationEvent?.entryType === 'navigation'; |
There was a problem hiding this comment.
Legit refactor, see comment in related DCR PR
Co-authored-by: Simon Adcock <simonadcock2@gmail.com>
Ad load time test resultsFor Test conditions:
|
arelra
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR removes Google Analytics from theguardian.com domain but not any other subdomains. Here is a list of the subdomains:
After this PR changes we shouldn't see:
window.gaDatawindow.googleAnalyticsObjectwindow.guardian.GAData(articles)window.guardian.config.googleAnalyticsWe still have
window.gaGlobalwhich is loaded by Google ads and we have no control to remove it.This was tested locally and no requests are made to google-analytics
Here are the other PRs related to this work guardian/dotcom-rendering#11470 and guardian/frontend#27188
Why?
The Guardian has been working carefully over the course of many years to build similar reporting capabilities as Google Analytics, using the Data Lakehouse. There are many tactical and strategic benefits in migrating use-cases to Ophan and subsequently removing GA, some large examples are consent (GA sits behind consent) and costs.