Add 300x50 ad size to mobile-sticky #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a42f821 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Ad load time test resultsFor Test conditions:
|
deedeeh
added
the
[beta] @guardian/commercial
|
🚀 0.0.0-beta-20240604172725 published to npm as a beta release |
dskamiotis
approved these changes
Jun 5, 2024
| @@ -389,7 +389,7 @@ const slotSizeMappings = { | |||
| mobile: [adSizes.fluid], | |||
| }, | |||
| 'mobile-sticky': { | |||
| mobile: [adSizes.mobilesticky, adSizes.empty], | |||
| mobile: [adSizes.mobilesticky, adSizes.empty, createAdSize(300, 50)], | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This enables a new ad size 300x50 to
mobile-sticky.I tested in CODE and using a VPN to be in a region that has a
mobile-stickyslot. Here is a screenshot fromgoogletag.openConsole()with the new size.Why?
This request was made by AdOps which will give us the opportunity to serve creatives in smaller size.