chore!: Merge packages #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arelra
force-pushed
the
ravi/merge-packages
branch
2 times, most recently
from
9f6d535
to
0deb52e
Compare
|
🚀 @guardian/commercial-bundle-v5.1.1-beta.1 published to npm as a beta release |
arelra
force-pushed
the
ravi/merge-packages
branch
2 times, most recently
from
0158431
to
40a0bf4
Compare
arelra
added
[beta] @guardian/commercial
|
🚀 @guardian/commercial-v7.1.1-beta.0 published to npm as a beta release |
Merged
4 tasks
arelra
force-pushed
the
ravi/merge-packages
branch
from
1321daf
to
cb6b2e7
Compare
arelra
added
[beta] @guardian/commercial
|
🚀 @guardian/commercial-v7.1.1-beta.1 published to npm as a beta release |
chrislomaxjones
approved these changes
May 30, 2023
Jakeii
approved these changes
May 30, 2023
Co-authored-by: Chris Jones <christopher.jones@guardian.co.uk>
Co-authored-by: Chris Jones <christopher.jones@guardian.co.uk>
arelra
force-pushed
the
ravi/merge-packages
branch
from
ee94d52
to
e37c84e
Compare
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Merges @guardian/commercial-core and @guardian/commercial-bundle
Main changes:
commercial-coreandcommercial-bundleno longer exist and are replaced by a single repocommercialsrc/coretsconfig.core.jsonto output indist/when buildingdist/bundle/dist/cjs/dist/esm/@guardian/commercialwill start at v8.0.0 which should avoid any clashes with previous tags and versionsOther:
baseUrl: 'src'so instead you can import fromcore/orprojects/Follow up:
noUncheckedIndexedAccesswhich is true forcorebut not the main source. This is has been ticketed as a follow up piece of work.Why?
Having separate core and bundle repos is primarily a legacy of having our code live across commercial and frontend repos. Core was intended to be a library of pure functions with stricter TypeScript rules. However since moving all code from frontend into commercial this distinction is less clear and causes an overhead in managing the two repos separately. By merging the two repos and aligning as much of the compilation rules as possible we can alleviate the overhead and reduce the complexity of our release process.