Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New event to represent a successful content decache #187

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

tonytw1
Copy link
Contributor

@tonytw1 tonytw1 commented Jan 6, 2021

What does this change?

Introduces an event to represent Fastly CDN decaches.

Includes some basic meta data which the consume may find useful.

Intended as a lightweight substitute of the crier Event which can be iterated on to better suit the decached content use case.

How to test

How can we measure success?

Have we considered potential risks?

Images

@tonytw1 tonytw1 changed the title Introduce a new event to advertise when a piece of content is success… New event to represent a successful content decache Jan 6, 2021
@tonytw1 tonytw1 marked this pull request as ready for review January 6, 2021 12:41
* the aliasPaths so that e.g. de-caching can be comprehensively
* triggered when the content is updated
*/
4: optional list<string> aliasPaths
Copy link
Member

@JustinPinner JustinPinner Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏👏 💯

Copy link
Member

@JustinPinner JustinPinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks grand to me 👍

@tonytw1 tonytw1 merged commit fd618e4 into master Jan 6, 2021
@tonytw1 tonytw1 deleted the fastly-decache-event branch March 8, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants