Add the ceasedToBeCanonicalAt datetime to evolved URL aliasPaths #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonytw1
reviewed
Feb 24, 2021
|
|
||
| 1: required string path | ||
|
|
||
| 2: required CapiDateTime ceasedToBeCanonicalAt |
There was a problem hiding this comment.
CapiDateTime is interesting; is there nothing more global available?
Looks like it's existing though so happy probably consistant with what other fields do.
There was a problem hiding this comment.
Yes, I just took a lead from elsewhere. I think it's to provide iso8601 formatting as standard.
tonytw1
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Ophan require visibility of the date at which an alias ceased to reflect the canonical path for the content. This PR restructures the thrift model by removing the previous
stringrepresentation and applies a newAliasPathtype.How to test
Ensure that aliasPaths are properly represented in Concierge responses, capi scala client models, crier events, pubflow monitoring events and fastly decache events.
How can we measure success?
The correct data appears in the correct places in the correct format? Success!
Have we considered potential risks?
We're now changing more of the existing model but the feature isn't widely adopted yet, and because use of these are opt-in we don't imaging seeing any unexpected failures.
Images
N/A