Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code element type fields #198

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Add code element type fields #198

merged 1 commit into from
Mar 29, 2021

Conversation

Fweddi
Copy link
Contributor

@Fweddi Fweddi commented Mar 19, 2021

What does this change?

See #36, #2586 and #2596.

Adds the 'code element type' to the capi model, along with html and language type fields.

This is ultimately to allow blocks of code to work in our developer blogs (previously these have been handled by html injection rather than content modelling).

How to test

I think we need to deploy a full pipeline from flex to concierge, including the models, and test the behaviour. But I need a second opinion on this.

@Fweddi
Copy link
Contributor Author

Fweddi commented Mar 19, 2021

I worry there is a conflict between the work here and the work on Concierge. There is a confusing difference between typeData (defined on the Asset struct, itself defined on the Element Struct) and codeTypeData (defined on the BlockElement struct). The code element type does not have any assets. Does this mean we don't need a typeData field, and potentially don't need to add a CodeElementGenerator at all?

@mchv
Copy link
Member

mchv commented Mar 19, 2021

@Fweddi I think you are mixing two things:

  • show-blocks which will show code and need changes from this PR
  • show-elements which will triggers CodeElementGenerator and related code. We may not need codeTypeData in elements, and I will sip without first.

@Fweddi
Copy link
Contributor Author

Fweddi commented Mar 29, 2021

@Fweddi I think you are mixing two things:

  • show-blocks which will show code and need changes from this PR
  • show-elements which will triggers CodeElementGenerator and related code. We may not need codeTypeData in elements, and I will sip without first.

Thanks Mariot - this cleared up things a lot!

@Fweddi Fweddi merged commit b11fdeb into master Mar 29, 2021
@Fweddi Fweddi deleted the fp/add-code-element-type branch March 29, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants