Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark content decached events with a published timestamp #206

Merged
merged 3 commits into from
Sep 17, 2021

Conversation

tonytw1
Copy link
Contributor

@tonytw1 tonytw1 commented Sep 17, 2021

What does this change?

Allows consumers to make informed decisions about older messages.
ie. This happened a week ago; I don't need to be retry it so aggressively or I can drop it.

  • Optional for backwards compatiblity

  • Choose not to use the fill CapiDateTime; these events aren't really about CAPI; it's what the crier package does; avoids cross package linkage.

  • published field name could have been dateTime (crier) or firstPublished etc. published seems the simplest descriptive verb.

How to test

How can we measure success?

Have we considered potential risks?

Images

Accessibility

Allows consumers to make informed decisions about older messages.
ie. This happened a week ago; I don't need to be retry it so aggressively.
@tonytw1 tonytw1 requested a review from a team as a code owner September 17, 2021 08:00
@davidfurey
Copy link
Member

I'm concerned that published could be confused with the time the article was published. There seems to be a convention of prefixing event or content to field names to avoid ambiguity. Perhaps eventPublished or eventTimestamp would be clearer?

@tonytw1
Copy link
Contributor Author

tonytw1 commented Sep 17, 2021

I'm concerned that published could be confused with the time the article was published. There seems to be a convention of prefixing event or content to field names to avoid ambiguity. Perhaps eventPublished or eventTimestamp would be clearer?

eventPublished is fine.

@davidfurey davidfurey merged commit 5537a7d into master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants