Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating sbt to 1.5.7 #209

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Updating sbt to 1.5.7 #209

merged 1 commit into from
Dec 20, 2021

Conversation

rowannekabalan
Copy link
Contributor

What does this change?

*Bump sbt to 1.5.7
*Swap out deprecated in syntax in build.sbt and other deprecated syntax

How to test

Compiled and successfully published locally.

How can we measure success?

TBA

Have we considered potential risks?

Low-risk change.

@rowannekabalan rowannekabalan requested a review from a team as a code owner December 20, 2021 13:38
JustinPinner
JustinPinner reviewed Dec 20, 2021
View reviewed changes
Copy link
Member

@JustinPinner JustinPinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Have you managed to +publishLocal and/or put out a snapshot or release candidate from this branch to make sure it all works as expected?

@rowannekabalan
Copy link
Contributor Author

Looks good. Have you managed to +publishLocal and/or put out a snapshot or release candidate from this branch to make sure it all works as expected?

Yep I've noted that in How to test. I've managed to run a successful +publishLocal with no problems

@rowannekabalan rowannekabalan merged commit a471e93 into master Dec 20, 2021
@rowannekabalan rowannekabalan deleted the bump-sbt branch December 20, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinPinner JustinPinner JustinPinner left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rowannekabalan @JustinPinner