Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #210

Merged
merged 6 commits into from
Feb 2, 2022
Merged

Upgrade dependencies #210

merged 6 commits into from
Feb 2, 2022

Conversation

JustinPinner
Copy link
Member

@JustinPinner JustinPinner commented Jan 14, 2022

What does this change?

Upgrade our dependencies and plugins to their latest available versions. This build brings in beta releases of some upstream libraries for testing while they have their own PRs open.

This branch was used to release the following builds;
content-api-models-json 17.3.0-beta.2 for scala 2.12
content-api-models-json 17.3.0-beta.2 for scala 2.13
content-api-models 17.3.0-beta.2
and
@guardian/content-api-models 17.3.0-beta.2 for typescript

(note that the maven links above may take some time to appear)

How to test

Testing the NPM build for vulnerabilities;

$ npm i @guardian/content-api-models@17.3.0-beta.2

added 15 packages, and audited 16 packages in 41s

found 0 vulnerabilities

How can we measure success?

Consumers build and test cleanly? Success!

Have we considered potential risks?

Risks should be minimal - it will require a specific action to incorporate this library into an application so nothing should inadvertently break (and we believe it's still fully functional anyway)

Images

N/A

Accessibility

@JustinPinner JustinPinner marked this pull request as ready for review January 19, 2022 17:26
@JustinPinner JustinPinner requested a review from a team as a code owner January 19, 2022 17:26
Copy link
Contributor

@rowannekabalan rowannekabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JustinPinner JustinPinner merged commit 30f2458 into master Feb 2, 2022
@JustinPinner JustinPinner deleted the jp/bump-thrift-version-0-15-0 branch February 8, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants