Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callout to capi thrift model #216

Merged
merged 7 commits into from
Nov 8, 2022
Merged

Conversation

marjisound
Copy link
Contributor

@marjisound marjisound commented Oct 21, 2022

What does this change?

This PR updates the capi model to introduce the callout element type.

This PR is the fifth step of the work for adding a new callout element in CAPI pipeline, as explained below:

  1. flexible-model: Add callout element to flexible content thrift model https://github.com/guardian/flexible-model/pull/52
  2. flexible-content: Consume callout version of flexible model https://github.com/guardian/flexible-content/pull/4233
  3. content-api/elasticsearch: Add callout element type to elasticsearch https://github.com/guardian/content-api/pull/2708
  4. content-api/porter: Add callout element type to porter https://github.com/guardian/content-api/pull/2704
  5. content-api-models: Add callout to capi thrift model (current PR)
  6. content-api/concierge: update content-api-models version to add callout in concierge https://github.com/guardian/content-api/pull/2705
  7. content-api-scala-client: Update capi model version Update capi model version content-api-scala-client#372

How to test

How can we measure success?

Have we considered potential risks?

Images

Accessibility

@marjisound marjisound changed the title add callout to capi thrift model Add callout to capi thrift model Oct 21, 2022
@marjisound
Copy link
Contributor Author

@marjisound marjisound marked this pull request as ready for review November 8, 2022 10:03
@marjisound marjisound requested a review from a team as a code owner November 8, 2022 10:03
Copy link
Member

@JustinPinner JustinPinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants